-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Image Handling and Open Wikidata Media within app #6187
Optimize Image Handling and Open Wikidata Media within app #6187
Conversation
I am also trying to implement the feature so that Wikidata opens in our app like the Explore section. Until then, the raised PR will handle this by redirecting the user to the website. Once I implement the in-app functionality, I will raise a new PR for that, as it will take some time to integrate Wikidata into the app like Explore. |
Would you mind creating an issue regarding this, and explain how it would work, ideally with mockup screenshots? Thanks! :-) |
I am currently working on this, but it is not yet complete. Once it is finished, I will create an issue and raise a PR. I will also provide a screen recording to demonstrate the functionality. In the meantime, you can merge this PR if there are no issues with it. Regarding the functionality, it works similarly to the Explore section: When we click on any contribution, it opens in MediaDetailPager, displaying the media details within our app. My idea is to implement the same behavior in the Nearby section - Instead of opening the image in a browser when clicking on a green pin and then on image which appears after this branch get merged , it should open directly inside our app. If you want me to raise the issue now, I can do so. However, if needed, I can raise it once the implementation is complete. |
Now it works like |
Screencast looks excellent! :-) |
Now I understand better. Either is fine with me. :-) |
I believe creating a new issue is no longer necessary since I have already merged the changes into this branch. |
Sounds good! |
…how-picture-thumbnail-
@nicolas-raoul Could you please review this before any more PRs get merged? |
Would you mind checking why CI is failing? |
@nicolas-raoul It may be failing because the GitHub token doesn't have access to write on PR discussions. I have written the steps to fix this issue in the PR below: Kindly check the token.
|
Generally working great, though I noticed a red pin item showing the image of the item I selected immediately before. Probably a race condition: screen-20250220-235004.mp4 |
Would it be possible to replace the "refresh" icon with a "loading" icon? You can reuse the one from the Review activity. |
I have added a clear step to ensure that in every process, the previously requested image is cleared before fetching the current image. This prevents any race conditions and ensures the correct image is displayed. |
…how-picture-thumbnail-' into Nearby-When-tapping-green-pin,-show-picture-thumbnail-
I think this might not be possible because the loading icon you're referring to is actually a ProgressBar: <ProgressBar
android:id="@+id/pb_review_image"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_centerInParent="true"
android:visibility="gone"
tools:visibility="visible" />
Since it's part of the layout rather than a standalone icon or animation, directly replacing the refresh icon with it wouldn't work. However, I will try:
|
Understood for the icon, thanks! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great, thanks!
Fixes #6182
Description: